chore(java/eks): refresh sample code and set Amazon EKS version as 1.31 #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guessi
force-pushed
the
refresh-java-eks
branch
from
31023b3 to
210adff
Compare
Contributor
|
We are getting the following error trying to build the project. /home/runner/work/aws-cdk-examples/aws-cdk-examples/java/eks/fargate-cluster/src/main/java/com/amazonaws/cdk/EksFargateStack.java:[5,58] package software.amazon.awscdk.cdk.lambdalayer.kubectl.v31 does not exist |
Contributor
Author
|
Forgot to add dependency. Let's check again. |
Contributor
Author
|
@kaiz-io any chance to review again? thanks! |
Contributor
|
Got an error with test. ==============================
building project: java/eks/fargate-cluster
==============================
Error: Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.540 s <<< FAILURE! -- in com.amazonaws.cdk.EksFargateStackTest
Error: com.amazonaws.cdk.EksFargateStackTest.testEksCluster -- Time elapsed: 0.006 s <<< ERROR!
java.lang.RuntimeException:
Error: Expected 1 resources of type Custom::AWSCDK-EKS-Cluster but found 0
@jsii/kernel.RuntimeError: Error: Expected 1 resources of type Custom::AWSCDK-EKS-Cluster but found 0 |
kaiz-io
added
the
response-requested
guessi
force-pushed
the
refresh-java-eks
branch
from
5882d0f to
fcc1838
Compare
Contributor
Author
|
@kaiz-io Just fixed missing update version string, please check again. Hopefully it's the last commit for the PR. |
github-actions
bot
removed
the
response-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have been improved
cdk.jsonaligned with whatcdk init app --language javawould generated (with latestcdkcommand)References
Additional notes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.